[Fwd: Request for review: libdnet]

[José Pedro Oliveira]

Oliver,

> SRPM & SPEC:
> http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/libdnet

Todo list:
* use "%setup -q" instead of %setup (-q -> quiet mode)
* use "make install DESTDIR=..." instead of %makeinstall
* wrong group in the progs subpackage
* %post/%postun scripts missing
* library (.so ) in the wrong package
* don't include the .la file
* missing doc files (LICENSE is critical)
* don't overuse the %attr macros. There is nothing wrong
  with the default file permissions
* don't use TABs in specfiles
* and run rpmlint before submitting a package for review

jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdnet.spec.patch
Type: text/x-patch
Size: 1891 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050713/a2a785a0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050713/a2a785a0/attachment.sig>