Request for review: bwm-ng

[Oliver Falk]

On 07/13/2005 06:00 PM, Matthias Saou wrote:
> Oliver Falk wrote :
> 
> 
>>>>Please review/approve.
>>>
>>>Noone saw this, did you?
>>
>>Still now answer? :-/
> 
> 
> Here's one :-)
> I'm a little lazy to list all the changes I've made... see the patch.
> 
> Main remarks :
> - Source URL wasn't valid anymore
Thanks.
> - Summary started with "A ..."
OK.
> - You seem to not be friends with tabulations ;-)
                 ^^^ I AM! :-)
> - Stripping must be avoided to get useful debuginfo packages
Oops.
> - You forgot to include the man page
OK.
> - Passing defaults to configure only decreases readability (IMHO)
Correct. Merci.

> And last, the big blocks of comments which are completely redundant with
> the spec file delimiter right below (i.e. %description, %prep, %build,
> %install...) should be avoided since they're not really useful as long as
> you have proper syntax colouring, and can trigger unwanted side-effects,
> most notably their inclusion into %pre*/%post* scriplets (although there
> are none in this particular packages).

This was a specfile template from my old company... :-) :-/

> Please merge in the changes that you like, then I'll review again.

Applied, please review/approve:
http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/bwm-ng

Best,
  Oliver