Review: perl-Crypt-CBC (script files marked as %doc)

[José Pedro Oliveira]

Andreas,

> 
>>>SPEC & SRPM: http://home.bawue.net/~ixs/perl-Crypt-CBC/
>>
>>Need to own one more dir, and eg/ is referred to in the docs, so it
>>would be good to include it.  See patch.
> 
> Kay.

script files as documentation
-----------------------------
When adding script files as documentation it is a good policy
to disable their execution permissions.  Not disabling them
sometimes introduces new requirements.

$ rpm -qplv /tmp/rpms/noarch/perl-Crypt-CBC-2.14-1.noarch.rpm
...
-rwxr-xr-x ... /usr/share/doc/perl-Crypt-CBC-2.14/eg/aes.pl
-rwxr-xr-x ... /usr/share/doc/perl-Crypt-CBC-2.14/eg/des.pl
-rwxr-xr-x ... /usr/share/doc/perl-Crypt-CBC-2.14/eg/idea.pl
...

$ rpm -qpR /tmp/rpms/noarch/perl-Crypt-CBC-2.14-1.noarch.rpm
...
perl(Crypt::CBC)
perl(Crypt::IDEA)
perl(Digest::MD5)
....

In particular, the package perl-Crypt-IDEA doesn't exists
in Core/Extras.


Solution:
Just add the following line (or something similar) to %prep section:

   chmod 644 eg/*.pl


Regards,
jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050714/861f5544/attachment.sig>