Review nautilus-open-terminal was Re: No more right click terminal

[Paul Nasrat]

> > > http://rpm.frields.org/FC5/nautilus-open-terminal/
> > > 

> 
> Done, requested cvsextras group membership to go with my other existing
> ones.  Paul N., are you willing to check this over?  If not, anyone
> else?

Review based on http://fedoraproject.org/wiki/PackagingGuidelines it's
been a while since I did QA.

Source against upstream and independant download:

http://manny.cluecoder.org/packages/nautilus-open-terminal/nautilus-open-terminal-0.4.tar.gz.md5
md5 931a50e602f60340a5ed369f50146f36  nautilus-open-terminal-0.4.tar.gz

Source License is GPL, no known legal issues.

Builds locally using rpmbuild and mock - so buildrequires form all
requirements.

Terminal menu appears after logout/login and using nautilus -q (tested
both mock built and system built package)

However:

rpmlint gives:
W: nautilus-open-terminal devel-file-in-non-devel-package /usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.a
E: nautilus-open-terminal
script-without-shellbang /usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.la

Indeed - you probably just want to nuke the .a and .la files

Paul