Request for a sponsor and a review of: pam_abl

[Tomas Mraz]

On Fri, 2005-07-15 at 09:46 +0200, Oliver Falk wrote:
> 31,33c38,40
> < install -D -m 644 conf/pam_abl.conf %{buildroot}/etc/security/pam_abl.conf
> < install -D -m 755 tools/pam_abl %{buildroot}/sbin/pam_abl
> < install -d -m 755 %{buildroot}%{_localstatedir}/lib/abl
> ---
> > install -D -m 644 conf/pam_abl.conf %{buildroot}/%{_sysconfdir}/security/pam_abl.conf
> > install -D -m 755 tools/pam_abl %{buildroot}/%{_sbindir}/pam_abl
> > install -d -m 755 %{buildroot}%{_localstatedir}/%{_lib}/abl
%{_sysconfdir} and %{_sbindir} begin with / already
And moreover the pam_abl binary should be probably installed in /sbin
and not /usr/sbin as you suggest by using %{_sbindir}.
%{_lib} after _localstatedir is wrong - it expands to lib64 on 64bit
arches.

> 44c51
> < %config(noreplace) /etc/security/pam_abl.conf
> ---
> > %config(noreplace) /%{_sysconfdir}/security/pam_abl.conf
The same as above.

> 46,47c53,54
> < /sbin/pam_abl
> < %{_localstatedir}/lib/abl/
> ---
> > %{_sbindir}/pam_abl
> > %{_localstatedir}/%{_lib}/abl/
Again.

-- 
Tomas Mraz <tmraz at redhat.com>