Review nautilus-open-terminal was Re: No more right click terminal

[Paul W. Frields]

On Fri, 2005-07-15 at 21:34 -0400, Paul Nasrat wrote:
> On Fri, 2005-07-15 at 18:25 -0400, Paul W. Frields wrote:
> > On Thu, 2005-07-14 at 17:30 -0400, Paul W. Frields wrote:
> > > On Thu, 2005-07-14 at 16:26 -0400, Paul Nasrat wrote:
> > > > > > > http://rpm.frields.org/FC5/nautilus-open-terminal/
> > > > > 
> > > > > Done, requested cvsextras group membership to go with my other existing
> > > > > ones.  Paul N., are you willing to check this over?  If not, anyone
> > > > > else?
> > > > 
> > > > Review based on http://fedoraproject.org/wiki/PackagingGuidelines it's
> > > > been a while since I did QA.
> > > > 
> > > > Source against upstream and independant download:
> > > > 
> > > > http://manny.cluecoder.org/packages/nautilus-open-terminal/nautilus-open-terminal-0.4.tar.gz.md5
> > > > md5 931a50e602f60340a5ed369f50146f36  nautilus-open-terminal-0.4.tar.gz
> > > > 
> > > > Source License is GPL, no known legal issues.
> > > > 
> > > > Builds locally using rpmbuild and mock - so buildrequires form all
> > > > requirements.
> > > > 
> > > > Terminal menu appears after logout/login and using nautilus -q (tested
> > > > both mock built and system built package)
> > > > 
> > > > However:
> > > > 
> > > > rpmlint gives:
> > > > W: nautilus-open-terminal devel-file-in-non-devel-package /usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.a
> > > > E: nautilus-open-terminal
> > > > script-without-shellbang /usr/lib/nautilus/extensions-1.0/libnautilus-open-terminal.la
> > > > 
> > > > Indeed - you probably just want to nuke the .a and .la files
> > > 
> > > Done.  See 0.4-3 at same location.  Sorry I missed the section on
> > > rpmlint; everyone has to start somewhere, I suppose.  I'll be sure to
> > > use it in the future (and reread spot's Guidelines).
> > 
> > Sorry to reply to myself.  New off-Broadway version 0.4-4 fixes other
> > discrepancies from spot's reviewer guidelines:
> > 
> > http://rpm.frields.org/FC5/nautilus-open-terminal/
> 
> I see nothing...
> 
> and I really want to get this through so we can concentrate on
> possibilities for it in Core...

That's decidedly weird, since it's there and I just tested it from an
external shell account.  Are you using a wacky browser (or wacky
settings) that reject frames?  I see some entries in my access log
purporting to be from a w3m client, which may or may not be you.  In any
case, you should be able to use:

http://www2.frields.org:8080/rpm/FC5/nautilus-open-terminal/

-- 
Paul W. Frields, RHCE                          http://paul.frields.org/
  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
 Fedora Documentation Project: http://fedora.redhat.com/projects/docs/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050715/0baa88e8/attachment.sig>