Request for review (round2): libxslt-plugin-regexp and libxslt-plugin-dates-and-time

[Rui Miguel Seabra]

On Sun, 2005-07-17 at 16:30 -0400, joel reed wrote:
> On Sun, Jul 17, 2005 at 03:19:28AM -0400, Ignacio Vazquez-Abrams wrote:
> > On Sat, 2005-07-16 at 22:43 -0400, joel reed wrote:
> > > http://home.comcast.net/~joelwreed/libxslt-plugin-regexp-0.5-1.src.rpm
> > > http://home.comcast.net/~joelwreed/libxslt-plugin-regexp.spec
> > 
> > - Build in mock failed due to missing BR of pcre-devel
> > - %{_libdir}/libxslt is unowned
> 
> can you tell me how to "own" this directory? the rpm must put
> the files here for libxslt to automatically load them. thanks.

%dir ...

> > - Odd spacing in %install and %files
> 
> could you be more specific? i'm not trying to be dense, but i don't
> see whats odd about the spacing...

The blank lines between some elements.
Remove them and you should be scott-free

> > ? Are you sure the minimum versions of libxml2 and libxslt are accurate?
> 
> the minimums reflect what i tested against. an earlier version or two
> may work, but i didn't want to put something in there i could not test. 

Maybe starting by not specifying a version until someone complains?

Rui

-- 
+ No matter how much you do, you never do enough -- unknown
+ Whatever you do will be insignificant,
| but it is very important that you do it -- Gandhi
+ So let's do it...?

Please AVOID sending me WORD, EXCEL or POWERPOINT attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050717/8d48db66/attachment.sig>