Please review: monotone

[Tom 'spot' Callaway]

On Mon, 2005-07-18 at 15:44 -0700, Roland McGrath wrote:
> Ok, let's get this show on the road.  There are several of us who have
> proposed monotone rpms.  I haven't heard anything like a clear approval,
> and I can't figure out who it is who ought to be stepping forward to do
> that.  I would be happy to be the maintainer, as probably would each other
> who has proposed it.  I'm ready to go right now if I can figure out what
> constitutes proper approval.
> 
> monotone 0.21 was just released, and it builds out of the box on FC4 and on
> rawhide.  Below is my current version of the spec file.  I've added the
> emacs support to the rpm.  I'll probably keep tweaking it, and may add some
> other stuff to make it simpler to run a monotone netsync server.  This
> works just fine as it is.  Someone please tell me to commit it already.

Review:

Good:
- rpmlint checks return nothing
- name is fine
- meets PackagingGuidelines
- license ok (GPL), license matches source, COPYING included
- spec is in am. english, legible
- sources match upstream (I presume, since you only gave us a spec)
- package compiles fine on fc4 (x86)
- no extra BR, no missing BR
- no locales
- no shared/static libs
- package is not relocatable
- owns all directories that it creates
- no duplicate files
- file permissions ok
- %clean ok
- macro use is consistent
- code not content
- nothing in %doc affects runtime
- no need for -docs, -devel

APPROVED. Commit this thing into CVS already. ;)

~spot
-- 
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!