packages for review: openbox and friends

[Michael Schwendt]

On Wed, 20 Apr 2005 08:12:35 -0400 (EDT), Chris Ricker wrote:

> <http://www.oobleck.net/kaboom/fedora/srpms/openbox-3.2-3.src.rpm>
> <http://www.oobleck.net/kaboom/fedora/srpms/obpager-1.8-1.src.rpm>
> <http://www.oobleck.net/kaboom/fedora/srpms/obconf-1.5-1.src.rpm>

openbox-3.2-5:

 * Fails to build here:

Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/qa/tmp/rpm/tmp/openbox-3.2-5-root-qa
error: Installed (but unpackaged) file(s) found:
   /usr/share/openbox/themeupdate.pyc
   /usr/share/openbox/themeupdate.pyo

 * Suggest adding "BuildRequires: gettext".

checking whether NLS is requested... yes
checking for msgfmt... no
checking for gmsgfmt... :
checking for xgettext... no
checking for msgmerge... no

 * Does "Conflicts: fluxbox <= 0:0.1.14" affect current fluxbox 0.9.x
   in Extras? What kind of conflict was this?

 * In %files section, %{_datadir}/openbox/ and
   %{_sysconfdir}/xdg/openbox/ are not included.

 * GPL not included in %doc.

[...]

obpager-1.8-1:

 * Had to look up http://dl.sf.net/obpager/obpager-1.8.tar.gz
   manually, since Source0 is not an URL.

 * %attr(...) usage most likely not necessary.

 * GPL not included in %doc (warning: file COPYING is +x)

[...]

obconf-1.5-1:

 * Had to look up http://icculus.org/openbox/obconf/obconf-1.5.tar.gz
   manually, since Source0 is not an URL.

 * %attr(...) usage most likely not necessary.

 * GPL not included in %doc.

 * hint: desktop-file-install has option --delete-original, so you
   could drop the extra rm -f ...

 * Directory %{_datadir}/obconf/ not included.