Request for review / approval: frotz.

[Michael Schwendt]

On Tue, 19 Jul 2005 09:58:33 -0500, Tom 'spot' Callaway wrote:

> On Tue, 2005-07-19 at 07:11 -0700, Chris Grau wrote:
> 
> > Here are the updated files:
> > 
> >   http://www.chrisgrau.com/packages/frotz/frotz.spec
> >   http://www.chrisgrau.com/packages/frotz/frotz-2.43-2.fc4.cdg.src.rpm
> 
> Review: frotz
> 
> Good:
> 
> - rpmlint checks return nothing
> - naming OK
> - meets PackagingGuidelines
> - License OK (GPL), matches code, text of license in %doc
> - source matches upstream
> - package compiles, builds, runs on FC4 (x86)
> - no locales
> - spec is legible, in am. english
> - no excluded BR, no missing BR
> - no shared/static libraries
> - no -devel/-docs
> - not relocatable
> - owns all directories it creates
> - file attribs ok
> - no duplicate files
> - %clean OK
> - macro use is consistent
> - code, not content
> - nothing in %doc affects runtime
> 
> APPROVED. Very good first package. :)
> 
> Now, what you need to do is go ahead and get an account here:
> https://admin.fedora.redhat.com/accounts/
> 
> When your paperwork is in, I'll sponsor you.
> 
> ~spot

Two hints here:

: %build
: sed -e "s/@@OPTS@@/$RPM_OPT_FLAGS/" Makefile > Makefile.tmp
: mv Makefile.tmp Makefile

sed -i (of at least FC2) can substitute in a file directly:

  sed -i -e "s/@@OPTS@@/$RPM_OPT_FLAGS/" Makefile

: make %{?_smp_mflags}
: gzip doc/frotz.6

Compressing manual pages manually is not necessary. rpmbuild does
this automatically. %{_mandir}/man6/frotz.6* in %files section then.

These may need investigation:

src/curses/ux_text.c: In function 'os_display_char':
src/curses/ux_text.c:209: warning: comparison is always true due to limited range of data type
src/curses/ux_text.c: In function 'os_char_width':
src/curses/ux_text.c:280: warning: comparison is always true due to limited range of data type