Request for review : gkrellm-bmp

[Michael Schwendt]

On Tue, 19 Jul 2005 09:50:08 +0200, Matthias Saou wrote:

> Brian Pepple wrote :
> 
> > On Thu, 2005-07-14 at 21:21 +0200, Matthias Saou wrote:
> > > Well, in that case, I'd be interested in hearing your comments regarding
> > > the possibility of having a "gkrellm-xmms" package that would obsolete
> > > "gkrellmms". You can find such a package next to the "gkrellm-bmp" one. A
> > > quick review of both would be much appreciated too ;-)
> > > 
> > 
> > The specs look ok, but [...]
> 
> Care to post a review? Still waiting for one :-)
> 
> gkrellm-xmms & gkrellm-bmp :
> http://ftp.es6.freshrpms.net/tmp/extras/

The "Conflicts" in there are unacceptable. gkrellm-xmms may obsolete and
provide gkrellmms in the usual way. But gkrellm-bmp must not use the same
file name for its plugin and locale files than gkrellm-xmms. If upstream doesn't like to rename the plugin, you could do it, e.g.: gkrellmms-bmp.so

--- gkrellm-bmp.spec.orig       2005-07-19 18:40:43.000000000 +0200
+++ gkrellm-bmp.spec    2005-07-19 18:44:55.000000000 +0200
@@ -41,18 +41,21 @@
 %{__make} install \
     DESTDIR="%{buildroot}" \
     PLUGIN_DIR="%{gkplugindir}" \
+    PACKAGE="gkrellmms-bmp" \
     enable_nls=1
-%find_lang gkrellmms
+mv %{buildroot}%{gkplugindir}/gkrellmms.so \
+    %{buildroot}%{gkplugindir}/gkrellmms-bmp.so 
+%find_lang gkrellmms-bmp
 
 
 %clean
 %{__rm} -rf %{buildroot}
 
 
-%files -f gkrellmms.lang
+%files -f gkrellmms-bmp.lang
 %defattr(-, root, root, 0755)
 %doc Changelog FAQ README
-%{gkplugindir}/gkrellmms.so
+%{gkplugindir}/gkrellmms-bmp.so
 
 
 %changelog