Request for review : gkrellm-bmp

Michael Schwendt bugs.michael at gmx.net
Tue Jul 19 17:55:59 UTC 2005


On Tue, 19 Jul 2005 19:36:50 +0200, Matthias Saou wrote:

> Michael Schwendt wrote :
> 
> [...] gkrellm-xmms and gkrellm-bmp build from the same sources [...]
> 
> > Apart from the same plugin name, they also share something else.
> 
> >From what I saw with the -DHAVE_BMP (from the top of my head), they seem
> to share pretty much everything except the external lib they link to, the
> string they display in gkrellm and the command they run by default. I
> assumed they wouldn't coexist peacefully (pretty much identical shared
> libs), which is why I went for the easy solution, the "Conflicts:" tags...
> 
> Not sure if it's really useful to try and make them play nice together,
> given that they're for the same use, so asking users to install either but
> not both doesn't seem like such an odd thing to do.

Other package conflicts were not permitted either. E.g. Sylpheed and
Sylpheed-Claws. 

All package conflicts are bad as they are ugly to deal with in package
tools.

Where "user == admin of a single-user system", it may not be a problem.
But whereas you can install XMMS and BMP at once in multi-user environments,
you could not do the same with the GKrellm plugins.

It's possible to rename all "gkrellmms_" symbols in the *.c/*.h files to
"gkrellmms_bmp_". But there's no guarantee this will still work as easily
in the future. The plugins also share the same name "GKrellMMS", so inside
GKrellm preferences you cannot see whether you look at the XMMS or BMP
plugin. This is less than ideal, too.




More information about the fedora-extras-list mailing list