Re-Request for review: kompose

[Dennis Gilmore]

Once upon a time Friday 22 July 2005 3:24 pm, Orion Poplawski wrote:
> Dennis Gilmore wrote:
> > i would change
> >
> > CFLAGS="$RPM_OPT_FLAGS" CXXFLAGS="$RPM_OPT_FLAGS" %configure
> > --disable-rpath make
> >
> > to
> >
> > unset QTDIR || : ; . /etc/profile.d/qt.sh
> > export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
> > %configure
> > make %{?_smp_mflags}
>
> Done.  Thanks for the QT stuff.

no probs.

> > use  desktop-file-install to install your .desktop file.  I dont think
> > your patch to the .desktop file is needed.  make sure you add
> > --vendor=fedora --add-category=X-Fedora  --delete-original
>
> I think I've got this right:
>
> %install
> %makeinstall
> desktop-file-install --vendor=fedora --add-category=X-Fedora \
>         --delete-original --dir %{buildroot}%{_datadir}/applications \
>         src/kompose.desktop
> rm $RPM_BUILD_ROOT%{_datadir}/applnk/Utilities/kompose.desktop
you shouldnt need to remove the .desktop file  thats what the 
--delete-original does  instead of src/kompose.desktop use the full path the 
the installed .desktop file
  ie $RPM_BUILD_ROOT%{_datadir}/applnk/Utilities/kompose.desktop

> > I have used the following script from Rex Deiter in the %install section 
> > to catch all the language stuff
<snip>
> > and then use  %files -f %{name}.lang instead of %files  to pick up all
> > the language files
No Probs
> Thanks!
>
> > kompose doesnt own /usr/share/apps/kompose/
>
> Changed %files to just list %{_datadir}/apps/kompose/
ok


Dennis