Review: perl-CGI-Simple

[José Pedro Oliveira]

Tom 'spot' Callaway wrote:
> ...
> All of these items are fixed in -3:
> 
> SRPM:
> http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Simple-0.077-3.src.rpm
> SPEC:
> http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Simple.spec
> 
> Please re-review or approve.

Approved.

Minor request:
When importing this module to CVS could you simplify and move the
permissions change to the %prep section?

Example:
----------
--- perl-CGI-Simple.spec.3      2005-07-28 04:40:27.000000000 +0100
+++ perl-CGI-Simple.spec        2005-07-30 04:23:43.000000000 +0100
@@ -17,9 +17,9 @@

 %prep
 %setup -q -n Cgi-Simple-%{version}
+chmod -x Changes README cgi-simple_vs_cgi-pm.html Simple.pm Simple/*.pm

 %build
-chmod -x Changes README cgi-simple_vs_cgi-pm.html
 %{__perl} Makefile.PL INSTALLDIRS=vendor
 make

@@ -29,8 +29,6 @@
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
 find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
 chmod -R u+w $RPM_BUILD_ROOT/*
-chmod -R 644 $RPM_BUILD_ROOT%{perl_vendorlib}/CGI/*.pm
-chmod -R 644 $RPM_BUILD_ROOT%{perl_vendorlib}/CGI/Simple/*.pm

 %check
 make test
----------

jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050730/98bf4c61/attachment.sig>