APPROVED Re: Request for review: koffice

[Warren Togami]

Andreas Bierfert wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Ok here we go, all new 1.4.1 koffice and koffice-langpack:
> 
> http://fedora.lowlatency.de/review/koffice.spec
> http://fedora.lowlatency.de/review/koffice-1.4.1-1.src.rpm

Please test for proper directory ownership as these packages are 
installed in dependency order.  Test it using a similar procedure to this:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=136030#c21

Remove all koffice directories after uninstalling the old koffice 
package if they still exist before doing the procedure.

> 
> http://fedora.lowlatency.de/review/koffice-langpack.spec
> http://fedora.lowlatency.de/review/koffice-langpack-1.4.1-1.src.rpm
> 

My only thought is perhaps the langpacks should not require an exact 
matching %{release}.  By requiring only a matching %{version}, then you 
can independently patch either package without necessitating a zero 
change rebuild of the other.  New langpacks are released with every new 
version right?

After this change to Requires, I suspect your koffice is ready so 
APPROVED.  If we find any further problems we can always rebuild.

Warren Togami
wtogami at redhat.com