Request for Review: sword

[Tom 'spot' Callaway]

On Fri, 2005-06-03 at 13:55 +0200, Nils Philippsen wrote:
> On Wed, 2005-06-01 at 18:27 -0500, Tom 'spot' Callaway wrote:
> > On Wed, 2005-06-01 at 15:50 +0200, Nils Philippsen wrote:
> > 
> > >  %install
> > > -rm -rf $RPM_BUILD_ROOT
> > > -make install DESTDIR=$RPM_BUILD_ROOT
> > > +rm -rf %buildroot
> > > +make install DESTDIR=%buildroot
> > >  %__mkdir_p %buildroot%_datadir/sword/modules
> > > 
> > >  find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'
> > > 
> > >  %clean
> > > -rm -rf $RPM_BUILD_ROOT
> > > +rm -rf %buildroot
> > 
> > FWIW, these changes are NOT necessary. $RPM_BUILD_ROOT is perfectly
> > valid and acceptable, as long as its consistent.
> 
> It wasn't consistent ;-) -- I could either replace %buildroot with
> $RPM_BUILD_ROOT or vice versa (which I did).

Whoops. Sorry. :)

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!