Request for Review: libevent

[Ville Skyttä]

On Mon, 2005-06-06 at 17:11 +0100, Paul Howarth wrote:
> José Pedro Oliveira wrote:
> > 1) move "make verify" to the %check section
> >    (it is processed after the %install section)
> > 
> >    %check || :
> >    make verify
> 
> Why the "|| :"?

http://rpm.org/max-rpm-snapshot/s1-rpm-inside-scripts.html#S3-RPM-INSIDE-CHECK-SCRIPT
(Be sure to check out footnote 2, too.)

> Wouldn't it be better to get the build to fail if the "make verify" fails?

Yes.  But "%check || :" != "make verify || :"