Request for Review: libevent

[Paul Howarth]

Ville Skyttä wrote:
> On Mon, 2005-06-06 at 17:11 +0100, Paul Howarth wrote:
> 
>>José Pedro Oliveira wrote:
>>
>>>1) move "make verify" to the %check section
>>>   (it is processed after the %install section)
>>>
>>>   %check || :
>>>   make verify
>>
>>Why the "|| :"?
> 
> 
> http://rpm.org/max-rpm-snapshot/s1-rpm-inside-scripts.html#S3-RPM-INSIDE-CHECK-SCRIPT
> (Be sure to check out footnote 2, too.)
> 
> 
>>Wouldn't it be better to get the build to fail if the "make verify" fails?
> 
> 
> Yes.  But "%check || :" != "make verify || :"

Right, got it thanks.

However... given that rpm 4.2 shipped way back with RH9, and the current 
extras system doesn't support anything older than FC3, is this something 
that should be done as standard? I personally like to maintain as much 
backwards compatibility as possible, but many things in extras seem to 
assume that things started with FC3. For instance, the perl module spec 
template uses MODULE_COMPAT, which doesn't work with RH9 or older perls.

Paul.