New Package: fish

[Axel Liljencrantz]

On 6/30/05, Michael Schwendt <bugs.michael at gmx.net> wrote:
> On Thu, 30 Jun 2005 15:00:31 +0200, Axel Liljencrantz wrote:
> 
> > > > Then here we go:
> > > >
> > > > http://roo.no-ip.org/fish/fedora/fish-1.11.1-7.src.rpm
> > >
> > > Apart from the from release number in the Changelog it now does look OK!
> >
> > It would seems that I manage to mess _something_ up in every new attempt. :(
> >
> > Here goes, the all singing, all dancing hamstergedon-enabled fish 1.11.1-8:
> >
> > http://roo.no-ip.org/fish/fedora/fish-1.11.1-8.src.rpm
> 
> Repeating my earlier hint (%configure macro sets CFLAGS already, Makefile.in
> adds the other flags, make target "all" is default):

Hmm, you are right, that is done automatically. But your patch changes
the CFLAGS part of the spec file back to the state it was in when I
originally submitted the package. I was told to change the CFLAGS
handling, and now I'm told to change it back to the way it was done in
the first place. Is this a disagreement on how the spec file should
look or an amusing method of confusing new packagers? :-o

> 
> --- fish.spec~  2005-06-30 14:58:09.000000000 +0200
> +++ fish.spec   2005-06-30 15:51:00.000000000 +0200
> @@ -20,7 +20,7 @@
>  %build
> 
>  %configure docdir=%_datadir/doc/%{name}-%{version}
> -make %{?_smp_mflags} all CFLAGS="$RPM_OPT_FLAGS -std=gnu99 -fno-strict-aliasing"
> +make %{?_smp_mflags}
> 
>  %install
>  rm -rf $RPM_BUILD_ROOT
> @@ -72,4 +72,4 @@
>  - Add macros to source tags
>  - Add smp_mflags to 'make all'
>  - Fix typo in post install scriptlet test
> -- Set CFLAGS from spec file
> \ No newline at end of file
> +- Set CFLAGS from spec file
> 
> 
> --
> Michael Schwendt <mschwendt at users.sf.net>
> Fedora Core release 4 (Stentz) - Linux 2.6.12-1.1385_FC4
> loadavg: 1.17 1.08 1.02
> 
> --
> fedora-extras-list mailing list
> fedora-extras-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-extras-list
> 

--
Axel