[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: fpc-2.0.0

Hi Joost,

Sorry for the slow follow up.

Joost van der Sluis wrote:
On Tue, 2005-05-24 at 13:22 +0900, Jens Petersen wrote:

It doesn't seem to build completely on x86_64, since
the libs are installed in /usr/lib and not /usr/lib64.

I've tried to fix that. Couldn't test it though, I don't have regular access to a x86_64 machine.

Thanks. Unfortunately it still isn't fixed - perhaps you can try to track down the problem by overriding _libdir yourself when building for i386.

- "examples/" seems to be too big to include in the main package:
  I recommend either excluding it or at least moving it to a -doc

I removed the examples and will make a -doc subpackage. Only thing is that that package must contain the full fpc-sources since the examples are spread throughout the sources. Is that ok?

How big will that make the -doc package? :)

- If more html documentation available, it could also go into -doc.
  I see there is a -docs subpackage on the upstream download page.

The documentation can be generated as .pdf or .html. (Both has some problems in the 2.0.0 release, but there are patches for that)

Probably just html is sufficient for the -doc package.

- the software is GPL/LGPL :), but are there any legal issues with
  highlighting TP and Delphi compatibility?

You mean problems with the 'TP and Delphi compatibility' statement? I
won't know why.

I mean they're probably registered trademarks and so on. Thought it was worth bringing up anyway... Anyone?

- (It would be nice if upstream could simplify building and installing
   without the setup.sh script?:)

Which script do you mean?

I mean just "configure; make; make install" rather than calling half a dozen make targets... more of an upstream rfe I suppose though. :)

The new spec-file and source rpm can be found here: (I also fixed Jochen
Schhmitt's comment)


Thanks. I attach some more fixes. Any reason not to own %{_libdir}/%{name} itself? I think fpc should.

diff -u fpc.spec-0.3 fpc.spec
--- fpc.spec-0.3	2005-06-01 18:04:37.000000000 +0900
+++ fpc.spec	2005-06-01 18:04:37.000000000 +0900
@@ -1,6 +1,6 @@
 Name:           fpc
 Version:        2.0.0
-Release:        0.3
+Release:        0.4
 Summary:        Free Pascal Compiler
 Group:          Development/Languages
@@ -58,7 +58,7 @@
                 INSTALL_LIBDIR=%{buildroot}%{_libdir} \
                 INSTALL_DOCDIR=%{buildroot}%{_defaultdocdir}/%{name}-%{version} \
                 INSTALL_BINDIR=%{buildroot}%{_bindir} \
-                FPCDIR=%{buildroot}%{_libdir}%{name}/%{version}"
+                FPCDIR=%{buildroot}%{_libdir}/%{name}/%{version}"
 make compiler_install ${INSTALLOPTS}
 make rtl_install ${INSTALLOPTS}
 make packages_install ${INSTALLOPTS}
@@ -71,7 +71,7 @@
 make man_install ${INSTALLOPTS} INSTALL_MANDIR=%{buildroot}%{_mandir}
 # create link
-ln -sf ../%{lib}/%{name}/%{version}/%{ppcname} %{buildroot}%{_bindir}/{%ppcname}
+ln -sf ../%{_lib}/%{name}/%{version}/%{ppcname} %{buildroot}%{_bindir}/%{ppcname}
 # Workaround:
 # newer rpm versions do not allow garbage
@@ -83,13 +83,13 @@
 # Create a version independent config
-%{_libdir}%{name}/%{version}/samplecfg %{_libdir}%{name}/%{version}
+%{_libdir}/%{name}/%{version}/samplecfg %{_libdir}/%{name}/%{version}
 %doc %{_defaultdocdir}/%{name}-%{version}/NEWS
 %doc %{_defaultdocdir}/%{name}-%{version}/README
 %doc %{_defaultdocdir}/%{name}-%{version}/readme.ide
@@ -98,15 +98,15 @@
 * Thu May 26 2005 Joost van der Sluis <joost cnoc nl> 2.0.0-0.3
-- replaced 'lib' and 'lib64' for %{lib}
+- replaced 'lib' and 'lib64' by %%{_lib}
 * Tue May 24 2005 Joost van der Sluis <joost cnoc nl> 2.0.0-0.2
 - Fixed for lib64 on x86_64
 - Changed summary, description and license
 - Removed examples from installation
 - Make clean removed from clean-section
 - Clean-up
-- replaced $RPM_BUILD_ROOT by %{buildroot}
+- replaced $RPM_BUILD_ROOT by %%{buildroot}
 * Mon May 23 2005 Joost van der Sluis <joost cnoc nl> 2.0.0-0.1
 - Initial build.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]