Request for Review: sword

[Nils Philippsen]

On Tue, 2005-05-31 at 03:34 -0700, Michael A. Peters wrote:
> http://mpeters.us/fc_extras/sword.spec
> http://mpeters.us/fc_extras/sword-1.5.8-0.1.src.rpm

I'd suggest these changes:

--- 8< ---
--- sword.spec.orig     2005-06-01 15:43:01.000000000 +0200
+++ sword.spec  2005-06-01 15:44:36.000000000 +0200
@@ -15,7 +15,7 @@
 BuildRequires: libidn-devel

 %description
-The SWORD Project is the CrossWire Bible Society\'s free Bible software
+The SWORD Project is the CrossWire Bible Society's free Bible software
 project. Its purpose is to create cross-platform open-source tools--
 covered by the GNU General Public License-- that allow programmers and
 Bible societies to write new Bible software more quickly and easily. We
@@ -43,21 +43,19 @@


 %install
-rm -rf $RPM_BUILD_ROOT
-make install DESTDIR=$RPM_BUILD_ROOT
+rm -rf %buildroot
+make install DESTDIR=%buildroot
 %__mkdir_p %buildroot%_datadir/sword/modules

 find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'

 %clean
-rm -rf $RPM_BUILD_ROOT
+rm -rf %buildroot


-%post
-/sbin/ldconfig
+%post -p /sbin/ldconfig

-%postun
-/sbin/ldconfig
+%postun -p /sbin/ldconfig


 %files
--- >8 ---

You could look into whether using %makeinstall instead of make install
DESTDIR=... is feasible. Don't forget bumping the release when building.

Besides that, sponsored and approved.

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011