Request for Review: sword

[Nils Philippsen]

On Wed, 2005-06-01 at 18:27 -0500, Tom 'spot' Callaway wrote:
> On Wed, 2005-06-01 at 15:50 +0200, Nils Philippsen wrote:
> 
> >  %install
> > -rm -rf $RPM_BUILD_ROOT
> > -make install DESTDIR=$RPM_BUILD_ROOT
> > +rm -rf %buildroot
> > +make install DESTDIR=%buildroot
> >  %__mkdir_p %buildroot%_datadir/sword/modules
> > 
> >  find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'
> > 
> >  %clean
> > -rm -rf $RPM_BUILD_ROOT
> > +rm -rf %buildroot
> 
> FWIW, these changes are NOT necessary. $RPM_BUILD_ROOT is perfectly
> valid and acceptable, as long as its consistent.

It wasn't consistent ;-) -- I could either replace %buildroot with
$RPM_BUILD_ROOT or vice versa (which I did).

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011