Package review requested: mock 0.2 and yum-utils 0.2
Aurelien Bompard
gauret at free.fr
Sun Jun 5 07:43:38 UTC 2005
mock:
- please give a full Source URL
- the URL tag is missing
- is "BuildRequires: gcc" really needed ?
- the buildroot is not the usual one (not very important, but...)
- the checks for '[ "$RPM_BUILD_ROOT" == "/" ]' are useless.
- the scriptlets should check for upgrade or fresh install
yum-utils:
- please give a full Source URL
- the URL tag is missing
- the buildroot is not the usual one
- yum already requires rpm and rpm-python, so those are not needed
- the checks for '[ "$RPM_BUILD_ROOT" == "/" ]' are useless.
Please fix those, and you're good to go.
Aurélien
--
http://aurelien.bompard.org ~~~~ Jabber : abompard at jabber.fr
En essayant continuellement, on finit par réussir. Donc plus ça rate, plus
on a des chances que ça marche. -- devise Shadok.
More information about the fedora-extras-list
mailing list