Request for Review: libevent

[José Pedro Oliveira]

Paul Howarth wrote:
> Ville Skyttä wrote:
> 
>> On Mon, 2005-06-06 at 17:11 +0100, Paul Howarth wrote:
>>
>>> José Pedro Oliveira wrote:
>>>
>>>> 1) move "make verify" to the %check section
>>>>   (it is processed after the %install section)
>>>>
>>>>   %check || :
>>>>   make verify
>>>
>>>
>>> Why the "|| :"?
>>
>>
>>
>> http://rpm.org/max-rpm-snapshot/s1-rpm-inside-scripts.html#S3-RPM-INSIDE-CHECK-SCRIPT
>>
>> (Be sure to check out footnote 2, too.)
>>
>>
>>> Wouldn't it be better to get the build to fail if the "make verify"
>>> fails?
>>
>>
>>
>> Yes.  But "%check || :" != "make verify || :"
> 
> 
> Right, got it thanks.
> 
> However... given that rpm 4.2 shipped way back with RH9, and the current
> extras system doesn't support anything older than FC3, is this something
> that should be done as standard? I personally like to maintain as much
> backwards compatibility as possible, but many things in extras seem to
> assume that things started with FC3. For instance, the perl module spec
> template uses MODULE_COMPAT, which doesn't work with RH9 or older perls.

Yes it does.  For RH8 and RH9 just install the package
perl-forward-compat available in te fedora.us mirrors.

There is also a version for rh7.x in the fedora.us bugzilla (never
publish though).

jpo
-- 
José Pedro Oliveira
* mailto: jpo at di.uminho.pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050606/232ca124/attachment.sig>