[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review and approval: octave-forge



On Tue, 2005-06-07 at 08:55 -0500, Quentin Spencer wrote:
> Sending this again because I haven't received any response from my 
> previous requests . . .  The package is in CVS.
> 
> octave-forge:  Contributed functions for octave


Hi Quentin,

I built octave-forge on a devel system and found the following:

  blocker:
  - missing:  BuildRequires: cln-devel

  not certain but perhaps needs some attention:
  - in %build, you "export LC_ALL" and I think that its a good idea
      to "unset LC_ALL" after the build
  - wrong-script-end-of-line-encoding for some files (pls see below) 
      which could be run through dos2unix or sed to clean-up
  - rpmlint reports "non-standard-dir-in-usr libexec" but the directory 
      appears to be both properly named and owned by the package so 
      its probably OK, right?

Otherwise, it looks OK.  Please fix the one blocker and I'll take
another look and send a more thorough review.

Ed

===  octave-forge wrong-script-end-of-line-encoding  ===

 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/mvaar.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/acovf.m
 /usr/share/octave/2.1.71/site/m/octave-forge/plot/peaks.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/rmle.m
 /usr/share/octave/2.1.71/site/m/octave-forge/signal/cheby2.m
 /usr/share/octave/2.1.71/site/m/octave-forge/signal/cheby1.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/aarmam.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/mvfreqz.m
 /usr/share/octave/2.1.71/site/m/octave-forge/strings/str2double.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/histo4.m
 /usr/share/octave/2.1.71/site/m/octave-forge/io/xlsread.m
 /usr/share/octave/2.1.71/site/m/octave-forge/signal/ellip.m
 /usr/share/octave/2.1.71/site/m/octave-forge/signal/butter.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/acorf.m
 /usr/share/octave/2.1.71/site/m/octave-forge/image/dilate.m
 /usr/share/octave/2.1.71/site/m/octave-forge/image/erode.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/bispec.m
 /usr/share/octave/2.1.71/site/m/octave-forge/tsa/y2res.m


-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 mit edu                ed eh3 com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]