Review request: drivel (GNOME blog client)

[Michael Schwendt]

On Sun, 12 Jun 2005 17:08:03 -0400, Jeremy Katz wrote:

> On Sun, 2005-06-12 at 17:04 -0400, seth vidal wrote:
> > On Sun, 2005-06-12 at 16:36 -0400, Jeremy Katz wrote:
> > > drivel is a blog client for GNOME supporting LiveJournal, MovableType,
> > > Blogger, Advogato and Atom.
> > > 
> > > SRPM at http://people.redhat.com/~katzj/drivel/drivel-2.0.0-2.src.rpm,
> > > Spec file at http://people.redhat.com/~katzj/drivel/drivel.spec

http://download.sourceforge.net/drivel/drivel-2.0.0.tar.bz2

> > Need to own:
> > %{_datadir}/omf/drivel/
> > %{_datadir}/pixmaps/drivel/
> > %{_datadir]/drivel/
> > %{_datadir}/gnome/help/drivel/

And when it's done with %dir statements, the sub-directories are needed,
too:

%dir %{_datadir}/drivel/glade/
%dir %{_datadir}/drivel/languages/

> %dir %{_datadir}/gnome/help/drivel
> %{_datadir}/gnome/help/drivel/*

A classic opportunity to reduce it to:
%{_datadir}/gnome/help/drivel/

> > otherwise I think it looks right.
> 
> Added and imported to the devel branch since I can't stand working with
> just a spec file anymore :)
> 
> Once it's got an approval, I'll make branches and build for all of FC3,
> FC4 and devel

For FC3 and newer you can drop those explicit dependencies on gtk2 and
glib2 minimal versions.

Missing "BuildRequires: gettext".

Where's GConf schema uninstall?

Desktop file is gnome-drivel.desktop not fedora-drivel.desktop, category
X-Fedora is missing.   Terminal=0  is not freedesktop.org standard, should
be Terminal=false