[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review request: drivel (GNOME blog client)



On Mon, 2005-06-13 at 00:14 +0200, Michael Schwendt wrote:
> And when it's done with %dir statements, the sub-directories are needed,
> too:

Cleaned up.

> For FC3 and newer you can drop those explicit dependencies on gtk2 and
> glib2 minimal versions.

Doesn't hurt to have them

> Missing "BuildRequires: gettext".

Added

> Where's GConf schema uninstall?

Added, although the snippets in the wiki seem far more verbose than
anything in Core is using.

> Desktop file is gnome-drivel.desktop not fedora-drivel.desktop, category
> X-Fedora is missing.   Terminal=0  is not freedesktop.org standard, should
> be Terminal=false

gnome-drivel is perfectly acceptable as it's an upstream gnome app.
Category added, I'll fix the Terminal via upstream for a future release
since the older values still work

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]