Request for Review: perl-Tk

[Steven Pritchard]

On Tue, Jun 14, 2005 at 05:54:43PM +0200, Andreas Bierfert wrote:
> perl-Tk-804.027:
> http://fedora.lowlatency.de/review/perl-Tk-804.027-1.src.rpm
> http://fedora.lowlatency.de/review/perl-Tk.spec

This has been on my list of things to submit for a while.  You might
want to look at my spec (attached).  Having XFT=1 on makes fonts look
*much* better, although it seems to make "make test" fail rather
miserably.  (The widget test and all of my code work perfectly though,
so I don't know why the tests fail.)

Steve
-- 
Steven Pritchard - K&S Pritchard Enterprises, Inc.
Email: steve at kspei.com             http://www.kspei.com/
Phone: (618)398-3000               Mobile: (618)567-7320
-------------- next part --------------
%{!?perl_vendorarch: %define perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo $installvendorarch)}

Name:           perl-Tk
Version:        804.027
Release:        1
Summary:        Graphical user interface toolkit for Perl
License:        GPL or Artistic
Group:          Development/Libraries
URL:            http://search.cpan.org/dist/Tk/
Source0:        http://www.cpan.org/modules/by-module/Tk/Tk-804.027.tar.gz
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
BuildRequires:  xorg-x11-devel
# For XFT=1.
BuildRequires:  fontconfig-devel
# Versions before this have known Unicode issues.
BuildRequires:  perl >= 3:5.8.3
# Looks like there is some breakage in the package.
# Apparently some things were renamed, but there are
# references to the old names.  Or something.
Provides:       perl(Tk::LabRadio) = 4.004
Provides:       perl(Tk::TextReindex)

%description
Graphical user interface toolkit for Perl.

%prep
%setup -q -n Tk-%{version}
find . -type f -exec %{__perl} -pi -e \
    's/^(#!)(\/usr\/local)?(\/bin\/perl)/$1\/usr$3/ if ($. == 1)' {} \;

%build
%{__perl} Makefile.PL INSTALLDIRS=vendor X11LIB=/usr/X11R6/%{_lib} XFT=1
%{__perl} -pi -e 's/^\tLD_RUN_PATH=[^\s]+\s*/\t/' Makefile
make %{?_smp_mflags}

%install
rm -rf $RPM_BUILD_ROOT

make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT

find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;
find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null \;

chmod -R u+rwX,go+rX,go-w $RPM_BUILD_ROOT/*

%clean
rm -rf $RPM_BUILD_ROOT

%files
%defattr(-,root,root,-)
%doc COPYING Change.log Changes Funcs.doc README ToDo VERSIONS
%{_bindir}/*
%{perl_vendorarch}/*
%{_mandir}/man1/*
%{_mandir}/man3/*

%changelog
* Sat Apr 02 2005 Steven Pritchard <steve at kspei.com> 804.027-1
- Specfile autogenerated.
- Fix various issues (wrong path to perl, broken auto-Provides, missing
  BuildRequires)