Request for review: ctrlproxy

[Michael Schwendt]

On Fri, 17 Jun 2005 18:01:29 +0100, David Woodhouse wrote:

> ctrlproxy is an IRC proxy capable of handling multiple client
> connections all using the same connection to an IRC server.
> 
> http://jelmer.vernstok.nl/ctrlproxy/
> 
> I based this on Sean Reifschneider's RPM which is linked from the
> ctrlproxy web page...
> 
> http://david.woodhou.se/ctrlproxy.spec
> http://david.woodhou.se/ctrlproxy-2.6.2-1.src.rpm

Many executable files make it into the binary packages:

 - all manual pages
 - C include file
 - a motd file

In the build log:

  checking pcre.h usability... no
  checking pcre.h presence... no
  checking for pcre.h... no
  checking openssl/ssl.h usability... no
  checking openssl/ssl.h presence... no
  checking for openssl/ssl.h... no

"man ctrlproxyrc" says: ``Ctrlproxy uses an XML file for
configuration. Check the ctrlproxyrc.example file for a good example.''
That file is _not_ included, but present in the source tarball.

A hint here, in %install:

> cd doc
> gzip -9 ctrlproxy.1 ctrlproxyrc.5 *.7ctrlproxy
> /usr/bin/install -d ${RPM_BUILD_ROOT}/%{_mandir}/man1
> /usr/bin/install ctrlproxy.1.gz ${RPM_BUILD_ROOT}/%{_mandir}/man1
> /usr/bin/install -d ${RPM_BUILD_ROOT}/%{_mandir}/man5
> /usr/bin/install ctrlproxyrc.5.gz ${RPM_BUILD_ROOT}/%{_mandir}/man5
> /usr/bin/install -d ${RPM_BUILD_ROOT}/%{_mandir}/man7
> /usr/bin/install *.7ctrlproxy.gz ${RPM_BUILD_ROOT}/%{_mandir}/man7

Manual pages are compressed automatically by rpmbuild. The effect of doing
it manually after "cd doc" is that a --short-circuit build of this package
won't work, i.e.  rpmbuild -bi --short-circuit ctrlproxy.spec  would fail
as you lost the uncompressed manual pages before.

Better: Don't compress them, install them uncompressed, and let rpmbuild
do the right thing.