[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request Review: perl-File-BOM



PUBLISH++

MD5SUMS:
5df57ec7fae5611e96b403f56fe72157  perl-File-BOM-0.09-0.1.src.rpm

907feafba72c9762b24c756ca1c0cb3d  File-BOM-0.09.tar.gz
f1a39d48a6a08bfd03206e1164187c27  perl-File-BOM.spec

Sources:
* File-BOM-0.09.tar.gz: MD5 digest OK (checked against CPAN copy)

Good:
* URL is valid
* License verified (Build.PL and META.yml)
* The build requirements are correct
* Uses perl(:MODULE_COMPAT_xxx)
* perl vendor libs present
* File permissions are OK (rpm -qplv ...)
* Builds without problems in FC3 and FC4
* (Un)installs without problems in FC3 and FC4
* No bugs listed in
  http://rt.cpan.org/NoAuth/Bugs.html?Dist=File-BOM

Notes:
* whenever possible we use
     %{perl_vendorlib}/File/
  instead of just
     %{perl_vendorlib}/*
  It makes life easier for reviewers when verifying directory
  and file ownerships
* the source url is now valid
* and don't forget to clean the comments ;)


jpo
-- 
José Pedro Oliveira
* mailto: jpo di uminho pt * http://gsd.di.uminho.pt/~jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
http://conferences.yapceurope.org/2005/ * http://braga.yapceurope.org/

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]