[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review: libevent


On Fri, 2005-06-17 at 16:31 +0100, José Pedro Oliveira wrote:

> >>>make install DESTDIR=$RPM_BUILD_ROOT
> >>
> >>%makeinstall worked fine for me
> > 
> > 
> > I have no particular love for one or the other. I'll change it.
> Don't change.
> make install is better as it allows to catch  configure/makefile
> problems (%makeinstall redefines a lot of variables that %configure
> should have initialized correctly).

this is funny. I can't count how many autofoo errors I have found with
using %makeinstall -- I think both have their merits, "make install
DESTDIR=..." spots missing $DESTDIR in installation rules,
"%makeinstall" spots illegal reuse of reserved directory variable names
and erroneous use of autoconf placeholders instead of variables (e.g.
"@bindir@" instead of "$(bindir)").

     Nils Philippsen    /    Red Hat    /    nphilipp redhat com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]