rpms/yumex/devel yumex.spec, NONE, 1.1 .cvsignore, 1.1, 1.2 sources, 1.1, 1.2

[Michael A. Peters]

The maintainer is working on getting his CVS access, but since I
imported it for him, I'll make sure to get in touch with him to fix
these issues.

On Wed, 2005-06-22 at 03:57 +0200, Michael Schwendt wrote:
> On Tue, 21 Jun 2005 11:51:14 -0400, Michael A. Peters wrote:
> 
> > Author: mpeters
> > 
> > Update of /cvs/extras/rpms/yumex/devel
> > In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv7375/devel
> 
> > --- NEW FILE yumex.spec ---
> 
> Missing BuildRequires: gettext
> 
> > Requires: yum >= 2.3.2
> > Requires: pygtk2
> > Requires: usermode
> > Requires: python-abi = %(%{__python} -c "import sys ; print sys.version[:3]")
> 
> python(abi) = ... dependency is automatic since FC4. For FC3, this
> package won't work anyway, because of the required Yum version.

So that should be removed?
The package is only suppose to target FC4/devel

> 
> > %install
> > [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
> 
> D'oh! What makes these checks come back from time to time?

I thought that was a matter of packager preference.

> 
> > desktop-file-install --vendor fedora --delete-original \
> >     --dir $RPM_BUILD_ROOT%{_datadir}/applications \
> >     --add-category X-Red-Hat-Base \
> 
> It's not a preferred Core application and hence must not add
> category X-Red-Hat-Base. Category X-Fedora is fine, although it's
> not evaluated anywhere.

X-Fedora is specified as being required here:
http://fedoraproject.org/wiki/Extras/FedoraDesktopEntryGuidelines

"Additionally, all Fedora packages must contain the "X-Fedora"
category."

X-Red-Hat-Base noted.
Thanks for the additional review