[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for review: ncmpc



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aurelien Bompard wrote:
> I used to have an ncmpc package in the Fedora.us QA queue, so here is
> basically the diff:

:)

>  - I would add this to %install:
> mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/ncmpc
> install -p -m644 doc/config.sample \
>     $RPM_BUILD_ROOT%{_sysconfdir}/ncmpc/config
> install -p -m644 doc/keys.sample $RPM_BUILD_ROOT%{_sysconfdir}/ncmpc/keys
> To create a config dir with example config files.

Done

>  - The docs are duplicated, and not installed in the standard dir. I'd add
> this to %install :
> rm -rf $RPM_BUILD_ROOT/%{_docdir}/%{name}
> and doc/ncmpc.lirc to the %doc in %files. And remove %{_datadir}/doc/* from
> the %files listing

Did it via exclude if you don't mind...

> That's all AFAIC. Consider it approved once it's done (and if you agree of
> course).

http://fedora.lowlatency.de/review/ncmpc-0.11.1-2.src.rpm
http://fedora.lowlatency.de/review/ncmpc.spec

Fine with you now?

- - Andreas
- --
Andreas Bierfert               | http://awbsworld.de      | GPG: C58CF1CB
andreas bierfert lowlatency de | http://lowlatency.de     | signed/encrypted
phone: +49 2402 102373         | cell: +49 172 9789968    | mail preferred
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFCut5CQEQyPsWM8csRArBQAKCSEQC23jQbHDpcUM4f6oDKA5NuZwCgjQYm
Ah3DK8eQzYhsIBHnrqdZbP4=
=gAAa
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]