pan from rawhide, modified

[Hans de Goede]

I've reviewed the spec, checked the md5sum and compiled the beast, it 
gives lots of (harmless) pointer signedess warnings. These drownout the 
usefull warnings.

So I added "export CFLAGS=-W-no-pointer-sign" above the %configure line 
in the spec, that makes it a lot better. Maybe its an idea to make this 
a default part of the spec. After this the only warnings left were:
---
/bin/sh: ./config.rpath: No such file or directory
+ make
gmime-message-partial.c: In function 'g_mime_message_partial_split_message':
gmime-message-partial.c:419: warning: function returns address of local 
variable
---

I don't know about the non-fatal config.rpath error, but the gcc warning 
is interesting. I've read the paricular piece of code and it could be 
safe and probably just works, but it ain't pretty.

Anyways the package is okay so I'll send an approved message to the 
commit-list.

Regards,

Hans




Michael A. Peters wrote:
> On Wed, 2005-06-22 at 06:51 +0200, Hans de Goede wrote:
> 
>>Michael A. Peters wrote:
>>
>>>Took latest pan from rawhide cvs and imported into extras
>>>updated version to new upstream version
>>>removed patches fixed in new upstream
>>>added gcc4 patch (won't build w/o it)
>>>removed gnet2 source - gnet2 in extras, BuildRequires gnet2-devel
>>>removed explicit library requires, redundant BuildRequires
>>>fedora extras style desktop-file-install
>>>changes noted in changelog
>>>
>>>builds in mock, rpmlint clean
>>>Any objections to requesting a build for FC-4?
>>>
>>>--
>>>fedora-extras-list mailing list
>>>fedora-extras-list at redhat.com
>>>https://www.redhat.com/mailman/listinfo/fedora-extras-list
>>>
>>
>>If you post a link to the spec and an md5 sum of the source tarball 
>>you're using I'll review it and assuming everything is ok approve it.
>>
>>Regards,
>>
>>Hans
> 
> 
> It's in CVS but here's the specfile:
> 
> http://mpeters.us/fc_extras/pan.spec
> http://mpeters.us/fc_extras/pan-0.14.2.91-2.src.rpm
> 
> md5sum rpm/SOURCES/pan-0.14.2.91.tar.bz2 
> 4770d899a1c1ba968ce96bc5aeb07b62  rpm/SOURCES/pan-0.14.2.91.tar.bz2
> 
> 
> --
> fedora-extras-list mailing list
> fedora-extras-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-extras-list
>