Request for review: fnfx
Andreas Bierfert
andreas.bierfert at lowlatency.de
Fri Jun 24 06:08:03 UTC 2005
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jason L Tibbitts III wrote:
> I'll give it a try, but since I don't have much experience, you should
> take these as topics for discussion instead of things that need to be
> fixed.
thanks :)
> Needs %{?dist} tag.
will add that once it is in cvs
> The Summary is not terribly descriptive. How about "Enables hotkey
> functions for Toshiba laptops"?
sounds good... done.
> I think "Prereq: /sbin/chkconfig" is preferred to the two Requires():
> lines but I am far from the authority here.
is it? I always used the preun post Requires... anybody to comment on this?
> You can use %{_initrddir} instead of %{_sysconfdir}/init.d
^^ missed that. done.
Here you go:
http://fedora.lowlatency.de/review/fnfx-0.3-2.src.rpm
http://fedora.lowlatency.de/review/fnfx.spec
So how about review/approval ;)
- - Andreas
- --
Andreas Bierfert | http://awbsworld.de | GPG: C58CF1CB
andreas.bierfert at lowlatency.de | http://lowlatency.de | signed/encrypted
phone: +49 2402 102373 | cell: +49 172 9789968 | mail preferred
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFCu6NDQEQyPsWM8csRArfnAJ496iCoy2TbHs6j9qi9SHF633WeKQCdEEtw
n+Dwq2OsCHX7L29E2DYyqZo=
=M8nZ
-----END PGP SIGNATURE-----
More information about the fedora-extras-list
mailing list