Request for Review: perl-Tk-JPEG-Lite

[Michael Schwendt]

On Tue, 14 Jun 2005 17:54:45 +0200, Andreas Bierfert wrote:

> http://fedora.lowlatency.de/review/perl-Tk-JPEG-Lite.spec
> http://fedora.lowlatency.de/review/perl-Tk-JPEG-Lite-2.01403-1.src.rpm
> 
> Summary: A lite version of Tk::JPEG
> 
> This is a "lite" version of Tk::JPEG which uses an already installed
> libjpeg shared library.

"BuildRequires:  libjpeg" looks wrong => libjpeg-devel?

> %setup -q -n Tk-JPEG-Lite-%{version}
> %{__perl} -pi -e 's|/usr/local/bin/perl\|/bin/perl|%{__perl}|' * */*

The OR part makes the expression fragile as e.g. it would substitute
/usr/bin/perl with /usr/usr/bin/perl. Better:

  %{__perl} -pi -e 's|/usr/local/bin/perl\|[^/usr]/bin/perl|%{__perl}|' * */*

More maintenance-free:

  find -type f | xargs %{__perl} -pi -e 's|/usr/local/bin/perl\|[^/usr]/bin/perl|%{__perl}|'


> INSTALLARCHLIB=$RPM_BUILD_ROOT%{perl_archlib}

Is this used actually? That would be outside vendor Perl locations.


No other things reviewed, as I don't have Perl::Tk yet.

-- 
Michael Schwendt <mschwendt at users.sf.net>
Fedora Core release 4 (Stentz) - Linux 2.6.11-1.1369_FC4
loadavg: 1.29 1.19 1.12