Request for review: openvpn

[Steven Pritchard]

On Mon, Jun 27, 2005 at 11:56:14AM -0600, Kevin Fenzi wrote:
> I use openvpn very heavily. It will be nice to get it into extras. ;) 

Thanks for taking a look at the package.

> Good stuff: 
> 
> - - sha1sum/gpg sig/md5sum all match for sources
> - - package builds fine on fc3, fc4, fc-devel (all x86)

For the record, I've build successfully for FC3/x86_64 and FC4/x86_64.

> Some issues from rpmlint: 

Unfortunately, I ran rpmlint *after* I put that rpm up.  I think I
have the issues it points out fixed in CVS though.  (I haven't tested
building what's there yet, but the changes seem obvious.)

> Perhaps these should be in a /usr/lib/openvpn/plugin/lib/ ?
> 
> E: openvpn arch-dependent-file-in-usr-share /usr/share/openvpn/plugin/lib/openvpn-auth-pam.so
> E: openvpn invalid-soname /usr/share/openvpn/plugin/lib/openvpn-auth-pam.so openvpn-auth-pam.so
> E: openvpn arch-dependent-file-in-usr-share /usr/share/openvpn/plugin/lib/openvpn-down-root.so
> E: openvpn invalid-soname /usr/share/openvpn/plugin/lib/openvpn-down-root.so openvpn-down-root.so

Moved.  I don't actually use any of the plugins though, so I don't
know if that will cause any issues.

> This isn't really a conf file is it: ?
> 
> W: openvpn conffile-without-noreplace-flag /etc/rc.d/init.d/openvpn
> E: openvpn executable-marked-as-config-file /etc/rc.d/init.d/openvpn

Aren't init scripts usually marked %config?

> 0 length file, should probibly not be included?
> 
> E: openvpn zero-length /usr/share/openvpn/easy-rsa/Windows/index.txt.start

I removed the whole easy-rsa/Windows directory.

> Might need to add a "processname: openvpn" and/or change the top
> description to just one line?
> 
> E: openvpn incoherent-subsys /etc/rc.d/init.d/openvpn openvpn"

Added.

Steve
-- 
Steven Pritchard - K&S Pritchard Enterprises, Inc.
Email: steve at kspei.com             http://www.kspei.com/
Phone: (618)398-3000               Mobile: (618)567-7320