[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: fish



Oliver Falk wrote:
* The rm after %install is more secure, if you write:

  [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

Same for the %clean section, of course.

Not necessary: any spec file in Fedora Extras should specify a BuildRoot: tag and that buildroot shouldn't point to the root directory. So the check is redundant.


Paul.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]