[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: fish



On 06/28/2005 11:00 AM, Paul Howarth wrote:
Oliver Falk wrote:

* The rm after %install is more secure, if you write:

  [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

Same for the %clean section, of course.


Not necessary: any spec file in Fedora Extras should specify a BuildRoot: tag and that buildroot shouldn't point to the root directory. So the check is redundant.

You are right, but for security reasons I believe it's better... Axel might add it or not - I don't _really_ care... :-)


Best,
 Oliver


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]