[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New Package: fish



On Tue, 28 Jun 2005 10:43:52 +0200, Oliver Falk wrote:

> * The rm after %install is more secure, if you write:
> 
>    [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
> 
>    Same for the %clean section, of course.

No, please don't recommend that. Besides decreasing readability, if some
user really tried to override the buildroot which is specified at the
top of the spec file and define it as '/', it would disable several of
rpmbuild's scripts. Additionally, there are other paths which somebody,
who doesn't know what he's doing, could specify with which to mess up a
system: /opt, /usr, //, /root, ~, to name a few. 

-- 
Michael Schwendt <mschwendt users sf net>
Fedora Core release 4 (Stentz) - Linux 2.6.11-1.1369_FC4
loadavg: 1.07 1.71 1.33


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]