Review requested: slmodemd

[Ralf Corsepius]

On Tue, 2005-06-28 at 15:22 +0200, Andreas Thienemann wrote:
> Hi,

> I'd be glad if someone could review the package for me, after which I'll 
> commit it to cvs.
> 
> SPEC: http://home.bawue.de/~ixs/slmodem/slmodem.spec
> SRPM: http://home.bawue.de/~ixs/slmodem/slmodem-alsa-2.9.9d-1.src.rpm

I am having several issues with this package.
* Missing COPYING
* Redundant Requires.
* Package doesn't acknowledge RPM_OPT_FLAGS
* Package doesn't compile with gcc-4.0.0 (fc4)

Below is a set of patches, I'd like to propose to resolve/work-around
the issues above.

BTW: What is the difference between slmodem-alsa-*.tar.gz and 
slmodem-*.tar.gz (I haven't checked the details)?

Ralf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: slmodem.spec.diff
Type: text/x-patch
Size: 1057 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050628/f5754da9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: slmodem-2.9.9d-gcc4.diff
Type: text/x-patch
Size: 415 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050628/f5754da9/attachment-0001.bin>