[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Review requested: slmodemd



On Tue, 2005-06-28 at 15:22 +0200, Andreas Thienemann wrote:
> Hi,

> I'd be glad if someone could review the package for me, after which I'll 
> commit it to cvs.
> 
> SPEC: http://home.bawue.de/~ixs/slmodem/slmodem.spec
> SRPM: http://home.bawue.de/~ixs/slmodem/slmodem-alsa-2.9.9d-1.src.rpm

I am having several issues with this package.
* Missing COPYING
* Redundant Requires.
* Package doesn't acknowledge RPM_OPT_FLAGS
* Package doesn't compile with gcc-4.0.0 (fc4)

Below is a set of patches, I'd like to propose to resolve/work-around
the issues above.

BTW: What is the difference between slmodem-alsa-*.tar.gz and 
slmodem-*.tar.gz (I haven't checked the details)?

Ralf

--- slmodem.spec.orig	2005-06-28 15:55:21.000000000 +0200
+++ slmodem.spec	2005-06-28 15:55:02.000000000 +0200
@@ -1,15 +1,15 @@
 Summary: ALSA-driver for the Smart Link HAMR5600 winmodem
 Name: slmodem-alsa
 Version: 2.9.9d
-Release: 1
+Release: 1%{?dist}
 Group: System Environment/Daemons
 License: BSD
 URL: http://www.smlink.com/content.aspx?id=132
 Source0: http://linmodems.technion.ac.il/packages/smartlink/slmodem-%{version}-alsa.tar.gz
 Source1: slmodemd.init
 Source2: slmodemd.sysconfig
+Patch0:  slmodem-2.9.9d-gcc4.diff
 BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot
-Requires: alsa-lib
 BuildRequires: alsa-lib-devel
 
 %description
@@ -22,10 +22,11 @@
 
 %prep
 %setup -q -n slmodem-%{version}-alsa
+%patch0 -p1
 
 %build
 pushd modem
-make SUPPORT_ALSA=1
+make SUPPORT_ALSA=1 EXTRA_CFLAGS="$RPM_OPT_FLAGS"
 popd
 
 %install
@@ -41,7 +42,7 @@
 
 %files
 %defattr (-,root,root)
-%doc README Changes
+%doc README Changes COPYING
 %{_sbindir}/slmodemd
 %{_sysconfdir}/init.d/slmodemd
 %config(noreplace) %{_sysconfdir}/sysconfig/slmodemd
--- slmodem-2.9.9d-alsa.orig/modem/modem.c	2005-04-23 03:11:27.000000000 +0200
+++ slmodem-2.9.9d-alsa/modem/modem.c	2005-06-28 15:42:22.000000000 +0200
@@ -1598,10 +1598,10 @@
 	return 0;
 }
 
+static int sregs_init(unsigned char sregs[]);
 
 int modem_reset(struct modem *m)
 {
-	static int sregs_init(unsigned char sregs[]);
 	MODEM_DBG("modem reset...\n");
 	if(m->state != STATE_MODEM_IDLE)
 		modem_hup(m,1);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]