Request for Review: hdf5 (was Re: hfd5 license)

[Tom 'spot' Callaway]

On Wed, 2005-06-29 at 15:22 -0600, Orion Poplawski wrote:

> Basically, the output of h5diff is different than expected.  Instead of 
> printing "<string of </g1>>" it prints "< of </>>".  It seems some 
> string buffer must get overritten.  Could not reproduce when compiled 
> with -g.

Very strange.

> - changed %install to use %makeinstall

Why? It doesn't change the file results.

> - don't we want some %docs?

Almost definitely. An oversight on my part.

> - we might want to specify "--enable-threadsafe --with-pthread" to 
> configure.  No realy opinion on this, but I could see it helping with 
> openmp programs.  Note that is has no effect on make check above.

Sounds good to me.

We might want to file the make check error upstream and see what they
think.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!