[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: New package: matplotlib



On Thu, 2005-06-30 at 14:22 -0600, Orion Poplawski wrote:
> Jeff Spaleta wrote:
> > On 6/28/05, Orion Poplawski <orion cora nwra com> wrote:
> > 
> >>Comments/suggestions?
> > 
> > 
> > I'd find it quite useful.  I don't have approval authority, but this
> > is a package I'd have a use for, so I'd be able to look over it and
> > help sort out any spec file issues that come up.
> > 
> > -jef
> > 
> 
> Please do.  I've installed on fc3 and fc4 myself without issue.
> 
> Can someone with approval authority review/approve?

Review:

Everything looks good except for four minor issues:

Bad:

- Should be named python-matplotlib
- No need for Requires: python (rpm picks it up as python(abi) = 2.4)
- changelog entry is missing a version
- Several directories are created but not owned by the package (this is
a pitfall of using a fileslist for the %files). You need to add:

%dir %{_libdir}/python2.4/site-packages/dateutil
%dir %{_libdir}/python2.4/site-packages/matplotlib
%dir %{_datadir}/matplotlib

rpmlint checks:
W: matplotlib no-version-in-last-changelog
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_zoom-out.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_left.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/util/__init__.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/standard.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_up.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/trait_errors.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/null/font_trait.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/tree_node.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/resource/__init__.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/null/color_trait.py
W: matplotlib hidden-file-or-dir /usr/share/matplotlib/.matplotlibrc
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/trait_numeric.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_save_as.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/null/rgb_color_trait.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/null/rgba_color_trait.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_refresh.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_down.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/help_template.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/has_traits.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/traits/ui/help.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/resource/resource_factory.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_close.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/util/resource.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/resource/resource_reference.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/resource/resource_manager.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_right.xpm
E: matplotlib
wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/matplotlib/enthought/resource/resource_path.py
E: matplotlib
wrong-script-end-of-line-encoding /usr/share/matplotlib/stock_zoom-in.xpm

Hooray! I don't think any of the e-o-l encoding is dangerous, unless
otherwise corrected, I'll assume these errors are safe to ignore. You
should put a version on your changelog though.

Good:

- Package meets PackagingGuidelines (except for minor naming issue)
- License (Python Software Foundation License) is ok, spec license
matches actual license, license text included
- Spec is in American English, and is legible
- Sources match upstream
- Package compiles and builds on x86 (FC4)
- Package has no extra BuildRequires
- Package is not missing any BuildRequires
- No locales to handle
- No shared library
- No need for -devel, -docs subpackages
- Not relocatable
- No duplicate files in %files
- %clean section included
- package is code, not content
- nothing runtime required in %doc
- no pkgconfig files, or static libraries, or headers
- no .la files

Push a new spec that makes those changes and I'll approve it.

~spot
-- 
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]