Review needed: xlockmore

Brian Pepple bdpepple at ameritech.net
Wed Mar 16 15:48:29 UTC 2005


On Wed, 2005-03-16 at 10:08 +0100, Adrian Reber wrote:
> http://lisas.de/~adrian/rpm/xlockmore-5.15-1.src.rpm

One quick minor thing I noticed is that you use %{buildroot} &
$RPM_BUILD_ROOT.  You should pick one and only use that in your spec,
per the wiki:

http://fedoraproject.org/wiki/PackagingGuidelines#head-
d0ada6130cf40be1244d34cc44fc38d34dd00db8

I should have a more complete review later today for you.

/B
-- 
Brian Pepple <bdpepple at ameritech.net>

gpg --keyserver pgp.mit.edu --recv-keys 810CC15E
BD5E 6F9E 8688 E668 8F5B  CBDE 326A E936 810C C15E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050316/2883673e/attachment.sig>


More information about the fedora-extras-list mailing list