clearlooks (was: Re: Review needed)

[Adrian Reber]

On Wed, Mar 16, 2005 at 12:38:44PM -0500, Ignacio Vazquez-Abrams wrote:
> I've imported the following packages into CVS:
> 
> clearlooks
[...]
> Please review them and notify me of any problems so I can fix them.

As I have also packaged clearlooks I had a look at it. The first problem
I encountered is that it doesn't build for me:

error: Installed (but unpackaged) file(s) found:
   /share/themes/Clearlooks/metacity-1/metacity-theme-1.xml


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /share/themes/Clearlooks/metacity-1/metacity-theme-1.xml
make: *** [i386] Error 1

I have done following changes to fix this and other minor stuff (better
link to the source, linebreak after 80 characters for %description) and
of course I have enabled the animation because that's where the fun starts.

diff -u -r1.2 clearlooks.spec
--- clearlooks.spec     16 Mar 2005 18:54:45 -0000      1.2
+++ clearlooks.spec     16 Mar 2005 20:11:44 -0000
@@ -5,23 +5,26 @@
 Group:          User Interface/Desktops
 License:        GPL
 URL:            http://clearlooks.sourceforge.net/screenshots/
-Source0:        http://prdownloads.sourceforge.net/clearlooks/clearlooks-0.4.tar.bz2
+Source0:        http://dl.sf.net/clearlooks/clearlooks-0.4.tar.bz2
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:  gtk2-devel
 
 %description
-Clearlooks will transform your GNOME desktop into an attractive looking and usable environment.
+Clearlooks will transform your GNOME desktop into an attractive looking and
+usable environment.
 
 %prep
 %setup -q
 
 %build
-%configure
+%configure --enable-animation
 make %{?_smp_mflags}
 
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
+cp -a $RPM_BUILD_ROOT/share/* $RPM_BUILD_ROOT/%{_datadir}
+rm -rf $RPM_BUILD_ROOT/share
 
 %clean
 rm -rf $RPM_BUILD_ROOT


		Adrian