Review Needed: python-{protocols, psycopg, simpletal, tpg, psyco}

[Shahms King]

On Mon, 2005-03-21 at 14:48 -0500, Ignacio Vazquez-Abrams wrote:
> On Mon, 2005-03-21 at 11:28 -0800, Shahms King wrote:
> > python-protocols -- PyProtocols 'adapt()' implementation
> 
> %python_sitearch is unused.

Fixed.

> Use -a 1 on %setup instead of untarring %SOURCE1 manually.

Fixed.

> Most of %files can be simplified to %{python_sitelib}/protocols.

Sadly, they cannot as the .pyo files need to be ghosted.

> Line spacing in %changelog.

Fixed.

> > python-psycopg   -- Alternative high-speed Postgres DB adapter
> 
> %python_sitearch is unused.

It was used in %files, but nowhere else. This has been fixed.

> Remove Requires: postgresql-libs.

Fixed.

> %build uses explicit paths instead of macros.

Fixed. 

> > python-simpletal -- Alternative implementation of Zope Page Templates
> 
> Most of %files can be simplified to %{python_sitelib}/simpletal.

Again, I wish they could be but the .pyo files need to be ghosted.

> Line spacing in %changelog.

Fixed.

> > python-tpg       -- Toy Parser Generator
> 
> %python_sitearch is unused.

Fixed.

> > python-psyco     -- Python specializing compiler
> 
> %python_sitearch is unused.

Actually, it's python_sitelib that's unused. Fixed.
I also added ExclusiveArch: i386 as that's the only supported
architecture.

> Most of %files can be simplified to %{python_sitelib}/psyco.

Again, need to ghost .pyo precludes simplifying the %files.


-- 
Shahms E. King <shahms at shahms.com>
Multnomah ESD

Public Key:
http://shahms.mesd.k12.or.us/~sking/shahms.asc
Fingerprint:
1612 054B CE92 8770 F1EA  AB1B FEAB 3636 45B2 D75B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050321/af8534c2/attachment.sig>