New Packages for Review: ladspa ladspa-cmt

[Michael Schwendt]

On Fri, 25 Mar 2005 01:32:20 -0600, Aaron VanDevender wrote:

> 
> I have some more packages for review.
> 
> ladspa (Linux Audio Developer's Simple Plugin API) is an sdk for writing
> portable audio plugins.
> http://renny.netdot.net/~sig/ladspa-1.12-1.src.rpm
> MD5 => fdff14ffffb4785e73a96f25fa73c5bd

ladspa exists in Extras already (1.12-3).
 
> ladspa-cmt (Computer Music Toolkit) is a library of LADSPA plugins with
> standard stuff like gain, delay, Freeverb, and sine.
> http://renny.netdot.net/~sig/ladspa-cmt-1.15-1.src.rpm
> MD5 => 74998892c1f3ad51f58100c457e91a5c

A couple of comments here.

> License:        LGPL

The included COPYING file and the source file headers say 'GPL'.
The COPYING file ought to be included in %doc.

> Group:          Development/Libraries

Since it's a plugin, not a development library, this group would be
misleading. Due lack of a more suitable group, I would choose
'Applications/Multimedia'.

> %build
> 
> cd src
> make %{?_smp_mflags} targets DESTDIR=$RPM_BUILD_ROOT

During %build, there should be no reason to set DESTDIR, as %build
should not install anything and the value in DESTDIR should not make
it into any built code or data file.

> mkdirhier $RPM_BUILD_ROOT/%{_libdir}/ladspa/

This is a binary provided by xorg-x11 only. Use "mkdir -p" instead.

> %files
> %defattr(-,root,root,-)
> %doc README doc
> #%{_bindir}/ladspa-*
> %{_libdir}/ladspa/*.so

With this alone, %_libdir/ladspa would not be included in this package.

The package doesn't "Requires: ladspa", so I tried to build it first for
another look. It didn't build, because it's missing "BuildRequires:
ladspa-devel".

> g++ -I/usr/include/ -Wall -Werror -O3 -fPIC   -c -o am.o am.cpp
> g++ -I/usr/include/ -Wall -Werror -O3 -fPIC   -c -o ambisonic.o ambisonic.cpp
> g++ -I/usr/include/ -Wall -Werror -O3 -fPIC   -c -o amp.o amp.cpp
> In file included from cmt.h:27,
>                  from amp.cpp:28:
> ladspa_types.h:27:20: error: ladspa.h: No such file or directory

After I had installed ladspa-devel, I got this (and re-running make
didn't fix it):

cc1plus: warnings being treated as errors
analogue.cpp: In static member function 'static void Analogue::run(void*, long unsigned int)':
analogue.cpp:259: warning: 'a' may be used uninitialized in this function
analogue.cpp:259: warning: 'b' may be used uninitialized in this function
analogue.cpp:259: warning: 'c' may be used uninitialized in this function
make: *** [analogue.o] Error 1
make: *** Waiting for unfinished jobs....

So, this package needs work.