evms review

[Tom 'spot' Callaway]

On Thu, 2005-03-17 at 16:54 +0100, Alain PORTAL wrote:

>Packages available from:
>http://linuxelectronique.free.fr/download/fedora/3/RPMS/i386/evms-2.5.2-0.fdr.1.i386.rpm
>http://linuxelectronique.free.fr/download/fedora/3/SRPMS/evms-2.5.2-0.fdr.1.src.rpm

Not bad, but there are some changes that need to be made.

Release:       0.fdr.1

Drop the 0.fdr.

Epoch:         0

Get rid of the zero Epoch.

Summary:       Enterprise Volume Management System (EVMS)

Drop the "(EVMS)", its not needed.

Group:         System Environment/Base

This group is really only for packages that the Core OS needs. Change it
to Applications/System.

Add BuildRequires: device-mapper

Use %setup -q.

Other than that, it looks good. Make the changes and I'll sponsor.

~spot
---
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!