Request for Review: dhcp-forwarder, dietlibc, ip-sentinel, util-vserver + xca

[Kevin Fenzi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Enrico" == Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> writes:

Enrico> Hi, it would be nice when somebody would review:

Enrico> * xca: Graphical X.509 certificate management tool

The FC-3 branch doesn't compile here: 
==============================

gcc -I. -I.. -I/usr/lib/qt-3.3/include -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -DPREFIX=\"/usr\"  -c clicklabel.cpp -o clicklabel.o
clicklabel.cpp: In constructor `ClickLabel::ClickLabel(QWidget*, const char*, uint)':
clicklabel.cpp:60: error: no match for call to `(QFont) ()'
make[2]: *** [clicklabel.o] Error 1
make[2]: Leaving directory `/home/kevin/projects/fedora-extras/xca/FC-3/xca-0.4.6/widgets'
make[1]: *** [widgets/target.obj] Error 2
make[1]: Leaving directory `/home/kevin/projects/fedora-extras/xca/FC-3/xca-0.4.6'
error: Bad exit status from /var/tmp/rpm-tmp.33985 (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.33985 (%build)
make: *** [i386] Error 1

On the devel branch:
================
package builds ok. 
rpmlint has: 

W: xca strange-permission xca-0.5.1.tar.gz 0664
E: xca configure-without-libdir-spec
E: xca wrong-script-end-of-line-encoding /usr/share/doc/xca-0.5.1/COPYRIGHT

In the spec: 

Does the %release_func work under fedora-extras? Or is that a
fedora.us thing? I suspec it doesn't as the release seems to be be -0
when it compiles here. 

Source0:        http://download.sourceforge.net/sourceforge/xca/%name-%version.tar.gz
I think it's prefered to list the exact name-version in there instead
of macros. Althought it's not set in stone according to
http://fedoraproject.org/wiki/PackagingGuidelines 

BuildRoot:      %_tmppath/%name-%version-%release-buildroot
The prevered value is
"%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)" 

Looks like a really nice package... 

kevin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCSiTx3imCezTjY0ERAr6LAKCWLoKyF1IV1LgecquEcHs5gK68oQCeMS+Q
SsqlaRNfTR/H8B8mCTVnAeY=
=gaYQ
-----END PGP SIGNATURE-----