Request for review: fyre

[Brian Pepple]

On Tue, 2005-03-29 at 19:00 -0500, Ignacio Vazquez-Abrams wrote: 
> fyre: A tool for creating artwork from chaotic functions


PUBLISH +1, after looking at rpmlint BuildRequires error.

MD5Sums:
fe9fcf511729eba8e78b657d1c10d506  fyre-1.0.0-3.src.rpm
d8919c5991bdf2e10934de780b21d351  fyre.spec
5da821b3166d3de187cc7d84bb1dc4d3  fyre-1.0.0.tar.bz2
a91acda90c5122efcde2ee136ba7b575  fyre-1.0.0-apps.patch

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Desktop entry is fine
* Package rebuilds as non-root user

Minor:
* Some minor features were left out of this build: OpenEXR & gnet

  I'm not familar with OpenEXR & gnet, so if there's a good reason not
to enable them, feel free to ignore this.

* Rpmlint errors: (E: fyre invalid-build-requires libglade2-devel)


/B
-- 
Brian Pepple <bdpepple at ameritech.net>

gpg --keyserver pgp.mit.edu --recv-keys 810CC15E
BD5E 6F9E 8688 E668 8F5B  CBDE 326A E936 810C C15E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-extras-list/attachments/20050330/d9f76fbc/attachment.sig>